deps: update reth from main (2026-06-13)#5564
Open
decofe wants to merge 10 commits into
Open
Conversation
shekhirin
previously approved these changes
Jun 11, 2026
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
mattsse
previously approved these changes
Jun 12, 2026
| .set_state_hook(Some(Box::new(move |state: &EvmState| { | ||
| hook_calls_clone.lock().unwrap().push(state.clone()); | ||
| .set_state_hook(Some(Box::new(move |state: EvmState| { | ||
| hook_calls_clone.lock().unwrap().push(state); |
Contributor
There was a problem hiding this comment.
this should be changed to parkinglot mutex separately
|
Hi @mattsse — your review approval was detected by Voight-Kampff, but there is no email mapping for your GitHub account, so no approval prompt can be sent to your device. Your review did not trigger an approval prompt and is not counted toward this PR. Because Voight-Kampff does not know which email address belongs to |
Thegreatsura
pushed a commit
to Thegreatsura/tempo
that referenced
this pull request
Jun 13, 2026
## Problem `FaucetArgs::enabled` uses the default clap id `enabled`. The reth bump in tempoxyz#5564 pulls in reth's new `JitArgs`, which also has an `enabled` field, so both flatten into the `node` command with the same id and clap's debug assert panics on any `tempo node` invocation: ``` Command node: Argument names must be unique, but 'enabled' is in use by more than one argument or group ``` This is what's failing CLI smoke tests / test (1/2) / test (2/2) on tempoxyz#5564. ## Fix Set an explicit `id = "faucet.enabled"` and update the four `requires`/`required_if_eq` references to match. Adds a parse sanity test. No behavior change — flag is still `--faucet.enabled`. (Companion reth PR gives `JitArgs` an explicit id too; either fix alone unblocks tempoxyz#5564.) --------- Co-authored-by: Alexey Shekhirin <github@shekhirin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated nightly update of reth dependencies from
paradigmxyz/rethmain branch.Upstream reth changes
72fafb5...606e2f1::warning::Failed to summarize upstream reth commits with Amp (exit 1)
reth download --forcecleanup (#25015)DatabaseStateProvider(#25121)MultiProofTargetsV2::from_state(#25144)Migrations
::warning::Failed to summarize source migrations with Amp (exit 1)
Cargo.toml | 128 +++++++++++++++++++-------------------
bin/tempo/src/cli.rs | 19 ------
bin/tempo/src/lib.rs | 14 ++---
crates/evm/src/block.rs | 8 +--
crates/payload/builder/src/lib.rs | 6 +-
5 files changed, 78 insertions(+), 97 deletions(-)
GitHub Workflow